Refactor edit post shortcuts to use the keyboard-shortcuts package #19320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
force-pushed
the
update/edit-post-shortcuts
branch
from
e8b8841 to
ed437ef
Compare
youknowriad
requested review from
ajitbohra,
chrisvanpatten and
mkaz
as code owners
youknowriad
force-pushed
the
update/edit-post-shortcuts
branch
from
ed437ef to
4abf7c6
Compare
youknowriad
force-pushed
the
update/edit-post-shortcuts
branch
from
4abf7c6 to
c47f1f4
Compare
aduth
reviewed
Jan 2, 2020
Comment on lines
+43
to
+47
| const formattingMethods = { | ||
| display: displayShortcut, | ||
| raw: rawShortcut, | ||
| ariaLabel: shortcutAriaLabel, | ||
| }; |
There was a problem hiding this comment.
Doubt it has much overhead, and I could grant an argument that it benefits from colocation, but this appears to be constant, could be defined at the top of the file.
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also refactored the components that I touched to use useSelect/useDispatch.
I've noticed that the "sidebar toggle" shortcut is not working but that's on master too.